-
Notifications
You must be signed in to change notification settings - Fork 121
Fixed visiblity of text on teh sponsors page dark mode #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Adez017 is attempting to deploy a commit to the recode Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs. In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊 Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv. We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰 🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨ 📚Your perks for contribution to this community 👇🏻
If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adez017 I see that, you had changed the txt colours but, Can you add something in the bg to differentiate it from the rest to improve UX ?
Hi @iitzIrFan , i appreciate that but i think we dont need it as far as visiblity concern i had made sure that when the pop up shows in the other background should a little blur that make it easy to read the pop up . i am attaching a video let me if if still needed that change Screen.Recording.2025-08-30.084900.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! @Adez017
@sanjay-kv Ready for Merge.
As of the new PR #465 , we loose the functionality of the previous card add your name here so this PR got invalid, |
@sanjay-kv Needs your thoughts on this ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Hi @sanjay-kv , i think you missed this : #464 (comment) |
can u look into the build fail
|
what are your thoughts @sanjay-kv ? The deploymenton will fail as mentioned in the above command , will need your thoughts and approval whether keep those changes or revert back |
check the comments once @sanjay-kv , its important |
your thought on this is good, even im having a rethought of bringing back the old design as that was more User friendly in the look and feel. we can bring back the old UI |
would i do that or you will do at your end? @sanjay-kv |
if the old UI is backed we can have this changes |
Can u bring back the change in new PR or something. @Adez017 once that's done we can merge this current PR. Meanwhile I will sponsor u on 15th of sept |
got it , ill be making a new PR with revert chnages .👍, thanks for the sponsorship in advance 😁 |
Description
now the text is clearly visible on the page with enhance fixes
Fixes #458
Type of Change
Changes Made
Updated css file
Dependencies
Checklist
npm run build
and attached scrrenshot in this PR.##Screenshots
