Skip to content

Conversation

Adez017
Copy link
Member

@Adez017 Adez017 commented Aug 29, 2025

Description

now the text is clearly visible on the page with enhance fixes

Fixes #458

Type of Change

  • New feature (e.g., new page, component, or functionality)
  • Bug fix (non-breaking change that fixes an issue)
  • UI/UX improvement (design, layout, or styling updates)
  • Performance optimization (e.g., code splitting, caching)
  • Documentation update (README, contribution guidelines, etc.)
  • Other (please specify):

Changes Made

Updated css file

Dependencies

  • List any new dependencies or tools required for this change.
  • Mention any version updates or configurations that need to be considered.

Checklist

  • My code follows the style guidelines of this project.
  • I have tested my changes across major browsers/devices
  • My changes do not generate new console warnings or errors , I ran npm run build and attached scrrenshot in this PR.
  • This is already assigned Issue to me, not an unassigned issue.

##Screenshots
image

Copy link

vercel bot commented Aug 29, 2025

@Adez017 is attempting to deploy a commit to the recode Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. The estimated time for response is 5–8 hrs.

In the meantime, please provide all necessary screenshots and make sure you run - npm build run , command and provide a screenshot, a video recording, or an image of the update you made below, which helps speed up the review and assignment. If you have questions, reach out to LinkedIn. Your contributions are highly appreciated!😊

Note: I maintain the repo issue every day twice at 8:00 AM IST and 9:00 PM IST. If your PR goes stale for more than one day, you can tag and comment on this same issue by tagging @sanjay-kv.

We are here to help you on this journey of open source. Consistent 20 contributions are eligible for sponsorship 💰

🎁 check our list of amazing people we sponsored so far: GitHub Sponsorship. ✨

📚Your perks for contribution to this community 👇🏻

  1. Get free Consultation use code recode50 to get free: Mentorship for free.

  2. Get the Ebook for free use code recode at checkout: Data Science cheatsheet for Beginners.

  3. Check out this weekly Newsletter: Sanjay's Newsletter.

If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@iitzIrFan iitzIrFan moved this to Done in @recode-web Aug 29, 2025
@iitzIrFan iitzIrFan moved this from Done to In Progress in @recode-web Aug 29, 2025
@iitzIrFan iitzIrFan added the under review Review under the maintainers or the admins label Aug 29, 2025
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Adez017 I see that, you had changed the txt colours but, Can you add something in the bg to differentiate it from the rest to improve UX ?

@Adez017
Copy link
Member Author

Adez017 commented Aug 30, 2025

@Adez017 I see that, you had changed the txt colours but, Can you add something in the bg to differentiate it from the rest to improve UX ?

Hi @iitzIrFan , i appreciate that but i think we dont need it as far as visiblity concern i had made sure that when the pop up shows in the other background should a little blur that make it easy to read the pop up . i am attaching a video let me if if still needed that change

Screen.Recording.2025-08-30.084900.mp4

@iitzIrFan iitzIrFan self-requested a review August 30, 2025 12:11
Copy link
Member

@iitzIrFan iitzIrFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! @Adez017
@sanjay-kv Ready for Merge.

@iitzIrFan iitzIrFan requested a review from sanjay-kv August 30, 2025 12:12
@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

As of the new PR #465 , we loose the functionality of the previous card add your name here so this PR got invalid,
If you think we still need that card i think we need to made some changes to be revert . Also i noticed previously we had both theme light and dark workign on this page , now we lost the functionality. to be honest as a contributing member for now abuot one month i think the previous is more good in the UX and also its well modularised . what do you think @iitzIrFan @sanjay-kv

@iitzIrFan
Copy link
Member

As of the new PR #465 , we loose the functionality of the previous card add your name here so this PR got invalid, If you think we still need that card i think we need to made some changes to be revert . Also i noticed previously we had both theme light and dark workign on this page , now we lost the functionality. to be honest as a contributing member for now abuot one month i think the previous is more good in the UX and also its well modularised . what do you think @iitzIrFan @sanjay-kv

@sanjay-kv Needs your thoughts on this !

Copy link
Member

@sanjay-kv sanjay-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome.

Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
recode-website Error Error Sep 2, 2025 5:08pm

@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

awesome.

Hi @sanjay-kv , i think you missed this : #464 (comment)

@sanjay-kv
Copy link
Member

can u look into the build fail

[00:08:14.282] Running build in Washington, D.C., USA (East) – iad1 [00:08:14.282] Build machine configuration: 4 cores, 8 GB [00:08:14.303] Cloning github.com/recodehive/recode-website (Branch: docs, Commit: a123b89) [00:08:16.284] Cloning completed: 1.981s [00:08:22.224] Restored build cache from previous deployment (6JcRofLbrZVXAG2XSA3a2W95xd4e) [00:08:23.114] Running "vercel build" [00:08:23.517] Vercel CLI 46.1.1 [00:08:24.127] Warning: Detected "engines": { "node": ">=18.0" } in your package.jsonthat will automatically upgrade when a new major Node.js Version is released. Learn More: http://vercel.link/node-version [00:08:24.131] Installing dependencies... [00:08:26.917] [00:08:26.918] up to date in 3s [00:08:26.918] [00:08:26.918] 422 packages are looking for funding [00:08:26.918] runnpm fund for details [00:08:26.960] Running "npm run build" [00:08:27.075] [00:08:27.076] > [email protected] build [00:08:27.076] > docusaurus build [00:08:27.076] [00:08:28.447] [INFO] [en] Creating an optimized production build... [00:08:29.007] [WARNING] Docusaurus found blog posts without truncation markers: [00:08:29.007] - "blog/spark-architecture/index.md" [00:08:29.007] - "blog/git-coding-agent/index.md" [00:08:29.007] - "blog/ux-ui-design-job/index.md" [00:08:29.008] - "blog/ux-designers-ai/index.md" [00:08:29.008] - "blog/streamline-ux-ui/index.md" [00:08:29.008] - "blog/google-deepmind/index.md" [00:08:29.008] - "blog/google-backlinks/index.md" [00:08:29.008] [00:08:29.008] We recommend using truncation markers (or{/* truncate */}) in blog posts to create shorter previews on blog paginated lists. [00:08:29.008] Tip: turn this security off with the onUntruncatedBlogPosts: 'ignore' blog plugin option. [00:08:29.605] [info] [webpackbar] Compiling Client [00:08:29.640] [info] [webpackbar] Compiling Server [00:08:41.004] [success] [webpackbar] Server: Compiled successfully in 11.36s [00:08:52.361] [success] [webpackbar] Client: Compiled with some errors in 22.76s [00:08:52.366] [ERROR] Client bundle compiled with errors therefore further build is impossible. [00:08:52.367] Syntax error: /vercel/path0/src/pages/our-sponsors/Sponsors.css Unclosed block (621:1) [00:08:52.367] [00:08:52.367] �[90m 619 | �[39m line-height�[33m:�[39m 1.6�[33m;�[39m [00:08:52.367] �[90m 620 | �[39m�[33m}�[39m [00:08:52.367] �[1m�[31m>�[39m�[22m�[90m 621 | �[39m�[33m[�[39mdata-theme=�[32m'dark'�[39m�[33m]�[39m �[33m.scanner-content�[39m �[33m{�[39m [00:08:52.367] �[90m | �[39m�[1m�[31m^�[39m�[22m [00:08:52.367] �[90m 622 | �[39m background�[33m:�[39m �[36mvar�[39m�[36m(--dark-bg-secondary)�[39m�[33m;�[39m [00:08:52.368] �[90m 623 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--dark-text-primary)�[39m�[33m;�[39m [00:08:52.368] [00:08:52.368] -------------------------- [00:08:52.368] [00:08:52.368] Syntax error: /vercel/path0/src/pages/our-sponsors/Sponsors.css Unclosed block (621:1) [00:08:52.368] [00:08:52.368] �[90m 619 | �[39m line-height�[33m:�[39m 1.6�[33m;�[39m [00:08:52.368] �[90m 620 | �[39m�[33m}�[39m [00:08:52.368] �[1m�[31m>�[39m�[22m�[90m 621 | �[39m�[33m[�[39mdata-theme=�[32m'dark'�[39m�[33m]�[39m �[33m.scanner-content�[39m �[33m{�[39m [00:08:52.368] �[90m | �[39m�[1m�[31m^�[39m�[22m [00:08:52.368] �[90m 622 | �[39m background�[33m:�[39m �[36mvar�[39m�[36m(--dark-bg-secondary)�[39m�[33m;�[39m [00:08:52.368] �[90m 623 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--dark-text-primary)�[39m�[33m;�[39m [00:08:52.368] -- inner error -- [00:08:52.368] [00:08:52.368] Syntax error: /vercel/path0/src/pages/our-sponsors/Sponsors.css Unclosed block (621:1) [00:08:52.368] [00:08:52.368] �[90m 619 | �[39m line-height�[33m:�[39m 1.6�[33m;�[39m [00:08:52.368] �[90m 620 | �[39m�[33m}�[39m [00:08:52.369] �[1m�[31m>�[39m�[22m�[90m 621 | �[39m�[33m[�[39mdata-theme=�[32m'dark'�[39m�[33m]�[39m �[33m.scanner-content�[39m �[33m{�[39m [00:08:52.369] �[90m | �[39m�[1m�[31m^�[39m�[22m [00:08:52.369] �[90m 622 | �[39m background�[33m:�[39m �[36mvar�[39m�[36m(--dark-bg-secondary)�[39m�[33m;�[39m [00:08:52.369] �[90m 623 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--dark-text-primary)�[39m�[33m;�[39m [00:08:52.369] Generated code for /vercel/path0/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[7].use[1]!/vercel/path0/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[7].use[2]!/vercel/path0/src/pages/our-sponsors/Sponsors.css [00:08:52.443] Error: Command "npm run build" exited with 1

@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

what are your thoughts @sanjay-kv ?
#464 (comment)

The deploymenton will fail as mentioned in the above command , will need your thoughts and approval whether keep those changes or revert back

@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

can u look into the build fail

[00:08:14.282] Running build in Washington, D.C., USA (East) – iad1 [00:08:14.282] Build machine configuration: 4 cores, 8 GB [00:08:14.303] Cloning github.com/recodehive/recode-website (Branch: docs, Commit: a123b89) [00:08:16.284] Cloning completed: 1.981s [00:08:22.224] Restored build cache from previous deployment (6JcRofLbrZVXAG2XSA3a2W95xd4e) [00:08:23.114] Running "vercel build" [00:08:23.517] Vercel CLI 46.1.1 [00:08:24.127] Warning: Detected "engines": { "node": ">=18.0" } in your package.jsonthat will automatically upgrade when a new major Node.js Version is released. Learn More: http://vercel.link/node-version [00:08:24.131] Installing dependencies... [00:08:26.917] [00:08:26.918] up to date in 3s [00:08:26.918] [00:08:26.918] 422 packages are looking for funding [00:08:26.918] runnpm fund for details [00:08:26.960] Running "npm run build" [00:08:27.075] [00:08:27.076] > [email protected] build [00:08:27.076] > docusaurus build [00:08:27.076] [00:08:28.447] [INFO] [en] Creating an optimized production build... [00:08:29.007] [WARNING] Docusaurus found blog posts without truncation markers: [00:08:29.007] - "blog/spark-architecture/index.md" [00:08:29.007] - "blog/git-coding-agent/index.md" [00:08:29.007] - "blog/ux-ui-design-job/index.md" [00:08:29.008] - "blog/ux-designers-ai/index.md" [00:08:29.008] - "blog/streamline-ux-ui/index.md" [00:08:29.008] - "blog/google-deepmind/index.md" [00:08:29.008] - "blog/google-backlinks/index.md" [00:08:29.008] [00:08:29.008] We recommend using truncation markers (``or{/* truncate */}) in blog posts to create shorter previews on blog paginated lists. [00:08:29.008] Tip: turn this security off with the onUntruncatedBlogPosts: 'ignore' blog plugin option. [00:08:29.605] [info] [webpackbar] Compiling Client [00:08:29.640] [info] [webpackbar] Compiling Server [00:08:41.004] [success] [webpackbar] Server: Compiled successfully in 11.36s [00:08:52.361] [success] [webpackbar] Client: Compiled with some errors in 22.76s [00:08:52.366] [ERROR] Client bundle compiled with errors therefore further build is impossible. [00:08:52.367] Syntax error: /vercel/path0/src/pages/our-sponsors/Sponsors.css Unclosed block (621:1) [00:08:52.367] [00:08:52.367] �[90m 619 | �[39m line-height�[33m:�[39m 1.6�[33m;�[39m [00:08:52.367] �[90m 620 | �[39m�[33m}�[39m [00:08:52.367] �[1m�[31m>�[39m�[22m�[90m 621 | �[39m�[33m[�[39mdata-theme=�[32m'dark'�[39m�[33m]�[39m �[33m.scanner-content�[39m �[33m{�[39m [00:08:52.367] �[90m | �[39m�[1m�[31m^�[39m�[22m [00:08:52.367] �[90m 622 | �[39m background�[33m:�[39m �[36mvar�[39m�[36m(--dark-bg-secondary)�[39m�[33m;�[39m [00:08:52.368] �[90m 623 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--dark-text-primary)�[39m�[33m;�[39m [00:08:52.368] [00:08:52.368] -------------------------- [00:08:52.368] [00:08:52.368] Syntax error: /vercel/path0/src/pages/our-sponsors/Sponsors.css Unclosed block (621:1) [00:08:52.368] [00:08:52.368] �[90m 619 | �[39m line-height�[33m:�[39m 1.6�[33m;�[39m [00:08:52.368] �[90m 620 | �[39m�[33m}�[39m [00:08:52.368] �[1m�[31m>�[39m�[22m�[90m 621 | �[39m�[33m[�[39mdata-theme=�[32m'dark'�[39m�[33m]�[39m �[33m.scanner-content�[39m �[33m{�[39m [00:08:52.368] �[90m | �[39m�[1m�[31m^�[39m�[22m [00:08:52.368] �[90m 622 | �[39m background�[33m:�[39m �[36mvar�[39m�[36m(--dark-bg-secondary)�[39m�[33m;�[39m [00:08:52.368] �[90m 623 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--dark-text-primary)�[39m�[33m;�[39m [00:08:52.368] -- inner error -- [00:08:52.368] [00:08:52.368] Syntax error: /vercel/path0/src/pages/our-sponsors/Sponsors.css Unclosed block (621:1) [00:08:52.368] [00:08:52.368] �[90m 619 | �[39m line-height�[33m:�[39m 1.6�[33m;�[39m [00:08:52.368] �[90m 620 | �[39m�[33m}�[39m [00:08:52.369] �[1m�[31m>�[39m�[22m�[90m 621 | �[39m�[33m[�[39mdata-theme=�[32m'dark'�[39m�[33m]�[39m �[33m.scanner-content�[39m �[33m{�[39m [00:08:52.369] �[90m | �[39m�[1m�[31m^�[39m�[22m [00:08:52.369] �[90m 622 | �[39m background�[33m:�[39m �[36mvar�[39m�[36m(--dark-bg-secondary)�[39m�[33m;�[39m [00:08:52.369] �[90m 623 | �[39m color�[33m:�[39m �[36mvar�[39m�[36m(--dark-text-primary)�[39m�[33m;�[39m [00:08:52.369] Generated code for /vercel/path0/node_modules/css-loader/dist/cjs.js??ruleSet[1].rules[7].use[1]!/vercel/path0/node_modules/postcss-loader/dist/cjs.js??ruleSet[1].rules[7].use[2]!/vercel/path0/src/pages/our-sponsors/Sponsors.css [00:08:52.443] Error: Command "npm run build" exited with 1

check the comments once @sanjay-kv , its important

@sanjay-kv
Copy link
Member

@Adez017

your thought on this is good, even im having a rethought of bringing back the old design as that was more User friendly in the look and feel. we can bring back the old UI

@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

@Adez017

your thought on this is good, even im having a rethought of bringing back the old design as that was more User friendly in the look and feel. we can bring back the old UI

would i do that or you will do at your end? @sanjay-kv

@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

if the old UI is backed we can have this changes

@sanjay-kv
Copy link
Member

Can u bring back the change in new PR or something. @Adez017 once that's done we can merge this current PR. Meanwhile I will sponsor u on 15th of sept

@Adez017
Copy link
Member Author

Adez017 commented Sep 2, 2025

Can u bring back the change in new PR or something. @Adez017 once that's done we can merge this current PR. Meanwhile I will sponsor u on 15th of sept

got it , ill be making a new PR with revert chnages .👍, thanks for the sponsorship in advance 😁

@sanjay-kv sanjay-kv closed this Sep 6, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in @recode-web Sep 6, 2025
@Adez017 Adez017 deleted the docs branch September 6, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

under review Review under the maintainers or the admins

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Text Not clearly visible on sponsors pop up

3 participants